Sfoglia il codice sorgente

Removes unnecessary comment.

Christopher Leggett 5 anni fa
parent
commit
7a2a908379
2 ha cambiato i file con 0 aggiunte e 22 eliminazioni
  1. 0 11
      public/js/app.js
  2. 0 11
      resources/js/components/credential.vue

+ 0 - 11
public/js/app.js

@@ -2412,17 +2412,6 @@ __webpack_require__.r(__webpack_exports__);
 
     console.log('credential.' + this.data.credid);
     Echo.channel('credential.' + this.data.credid).listen('CredentialUpdated', function (e) {
-      // This part could potentially use a refactor.
-      // Probably needs a credential list component to listen for this
-      // even and update the corresponding credential. Currently every
-      // credential on the page receives this event and checks whether it was intended
-      // for its credential or not. I would imagine this could cause a problem
-      // on the group page, which will potentially have a lot more credentials from
-      // various assets. Better solution may be to have a credentials list component
-      // That listens for credential update events and updates the appropriate credential.
-      // There would still be multiples of those on the group credentials page, but an
-      // order of magnitude less of those than of individual credentials.
-      // It also may not be a big deal performance wise to do it like this, not sure.
       _this.data = e.credential;
     });
   },

+ 0 - 11
resources/js/components/credential.vue

@@ -54,17 +54,6 @@ export default {
         console.log('credential.'+this.data.credid)
         Echo.channel('credential.'+this.data.credid)
             .listen('CredentialUpdated', (e) => {
-                // This part could potentially use a refactor.
-                // Probably needs a credential list component to listen for this
-                // even and update the corresponding credential. Currently every
-                // credential on the page receives this event and checks whether it was intended
-                // for its credential or not. I would imagine this could cause a problem
-                // on the group page, which will potentially have a lot more credentials from
-                // various assets. Better solution may be to have a credentials list component
-                // That listens for credential update events and updates the appropriate credential.
-                // There would still be multiples of those on the group credentials page, but an
-                // order of magnitude less of those than of individual credentials.
-                // It also may not be a big deal performance wise to do it like this, not sure.
                 this.data = e.credential;
             });
     },